Do not render the strong tag unnecessarily #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reason for this change? Also, if you remove the opening tag, then please also remove the closing tag. |
The tag is rendered twice as noticed in #52 so this removed the redundant tag. |
I'm going to fix this soon |
kocsismate
force-pushed
the
remove-class-strong
branch
from
9772818 to
42264e5
Compare
|
Issues are fixed, and I created php/web-php#429 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed in #52 (comment)
Requires a followup PR to https://github.com/php/web-php/blob/60a5f74b485075f8fbf2ceef988d343e0157666c/styles/theme-medium.css#L119 in order to display interface names on class synopses the same way as class names.